-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix drag and drop in FlatList while in strict mode #2413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally tested ✅
# Conflicts: # yarn.lock
group review: reverse the states as in always show edit controls, toggle button hides them, and then shows drag handles. move edit toggle to the left/in line with avatars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we decided to use drag handles during mob review, but it looks like we can't drag and drop using only keyboard anymore after commit 1c49f10. This tradeoff might be worth considering if we go with the current solution.
good catch @tony-tvu! i think that's a focus issue- once focused on the list item you should be able to tab again to focus on the drag handle. when i migrated it to FlatList i forgot about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
whoops, needed to update the tests too @tony-tvu my bad! should be good to go now. running a full make check on my end to make sure the rest passes |
Co-authored-by: Katie Sydlik-Badgerow <[email protected]>
This PR fixes part of #2412 the drag and drop functionality when in Strict Mode by replacing the current DND library we use (
react-beautiful-dnd
) withreact-dnd
, asreact-beautiful-dnd
is no longer being maintained.Also does some cleaning up in
FlatList
, simplifying some function calls and organizing the functions to make a bit more sense overall.out of scope:
PolicyStepsCard
react-beautiful-dnd
and@types/react-beautiful-dnd
packages afterwards