admin: provide URLs and copy links from the admin page #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
reviewed
Dec 2, 2019
|
Are these really hints as much as they are integration attributes? Just want to make sure we have the right naming since it looks like so far all of the "hints" are URLs |
|
We can't count on them always being URLs, we should also avoid using terms like "integration" here since we already use that for a separate purpose elsewhere. I used "hints" because it's general and use-cases can vary, meaning you might use/change the value in the external system in some cases. Open to other suggestions though. |
Co-Authored-By: David Talbot <[email protected]>
Forfold
requested changes
Dec 3, 2019
There was a problem hiding this comment.
Since the fields are editable still (rather than just a hint of a link you can copy), I think we should render this the same as the other text fields, with an end adornment in the text field displaying the copy icon. We can still leave the text field filled in though if we want them to be differentiated from the other config values. What do you think?
|
@Auchindoun They are read-only and non-editable. Displaying the link, instead of just a copy label like integration keys, so that it's easy to copy part of a URL and see the full structure based on what they need to achieve. |
dctalbot
previously approved these changes
Dec 3, 2019
arurao
approved these changes
Dec 10, 2019
KatieMSB
approved these changes
Dec 10, 2019
Forfold
approved these changes
Dec 12, 2019
Forfold
added a commit
that referenced
this pull request
Dec 12, 2019
* ui/overrides: show errors on user conflict (#182) * show errors on failure for user overrides * show field errors properly * remove redundant icon props * update userErrors array to be more understandable * build(deps): bump @material-ui/core from 4.6.1 to 4.7.0 in /web/src (#217) Bumps [@material-ui/core](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/mui-org/material-ui/releases) - [Changelog](https://github.com/mui-org/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui-org/material-ui/commits/v4.7.0/packages/material-ui) Signed-off-by: dependabot-preview[bot] <[email protected]> * ep repeat count never negative (#228) * graphql: update gqlgen to v0.10.1 (#200) * update gqlgen * remove old alertlog.Entry interface * rename rawentry -> entry.go * update playground and set Referrer-Policy * return validation error on CM not found * set content-type on graphql requests * set content-type in cypress graphql calls * update direct deps * build(deps-dev): bump cypress-plugin-retries in /web/src (#230) Bumps [cypress-plugin-retries](https://github.com/Bkucera/cypress-plugin-retries) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/Bkucera/cypress-plugin-retries/releases) - [Commits](kuceb/cypress-plugin-retries@v1.4.0...v1.5.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * dev: add Makefile commands for building CI test input (#229) * add makefile commands for building test bundle * always "bundle" dist binaries * ui: remove memoize from urlParamSelector (#226) * Fix bug in schedule shifts list to begin on current day * ui: update @material-ui/lab and convert SpeedDial to hooks (#204) * upgrade @hot-loader/react-dom @material-ui/core @material-ui/icons @types/luxon connected-react-router * upgrade history luxon mdi-material-ui husky * upgrade react react-dom react-ga react-router-dom terser-webpack-plugin ts-loader typescript webpack webpack-dev-server * oops, forgot the lockfile * WIP: convert speed dial to hooks, upgrade pkg * style tooltip labels * stop reversing every actions array * update speed dial tests * combine selectors * upgrade @material-ui/lab * bundle * Revert "stop reversing every actions array" This reverts commit 41cd2fe. * remove comments of perplexion * upgrade @material-ui/lab * use the handle naming convention set by jsx-handler-names * makeStyles with obj * inline w anonymous funs * build(deps-dev): bump @babel/cli from 7.7.0 to 7.7.4 in /web/src (#234) Bumps [@babel/cli](https://github.com/babel/babel) from 7.7.0 to 7.7.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.0...v7.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * alerts: create alerts for multiple services at once (#173) * don't use FormDialog for url-provided-error dialog * getServiceLabel util & unit test * add additional test cases * new create alert flow Co-Authored-By: Nathaniel Caza <[email protected]> * ui/cypress: add retry plugin for console output in CI (#233) * add retry plugin for console output in CI * add plugin for CI * smoketest/harness: ensure datagen always returns unique values (#237) * build(deps-dev): bump @babel/plugin-syntax-dynamic-import in /web/src (#236) Bumps [@babel/plugin-syntax-dynamic-import](https://github.com/babel/babel) from 7.2.0 to 7.7.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.2.0...v7.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump @babel/preset-react in /web/src (#235) Bumps [@babel/preset-react](https://github.com/babel/babel) from 7.7.0 to 7.7.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.0...v7.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump @babel/plugin-transform-runtime in /web/src (#231) Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel) from 7.6.2 to 7.7.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.6.2...v7.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump raw-loader from 3.1.0 to 4.0.0 in /web/src (#240) Bumps [raw-loader](https://github.com/webpack-contrib/raw-loader) from 3.1.0 to 4.0.0. - [Release notes](https://github.com/webpack-contrib/raw-loader/releases) - [Changelog](https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/raw-loader@v3.1.0...v4.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * go: linting fixes (#242) * run gofmt with -s * fix spelling mistakes * build(deps): bump connected-react-router from 6.6.0 to 6.6.1 in /web/src (#239) Bumps [connected-react-router](https://github.com/supasate/connected-react-router) from 6.6.0 to 6.6.1. - [Release notes](https://github.com/supasate/connected-react-router/releases) - [Commits](supasate/connected-react-router@v6.6.0...v6.6.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump mdi-material-ui from 6.8.0 to 6.9.0 in /web/src (#245) Bumps [mdi-material-ui](https://github.com/TeamWertarbyte/mdi-material-ui) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/TeamWertarbyte/mdi-material-ui/releases) - [Commits](TeamWertarbyte/mdi-material-ui@v6.8.0...v6.9.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * go: update direct deps (#252) * update direct deps * run tidy * build(deps): bump @material-ui/core from 4.7.0 to 4.7.1 in /web/src (#248) Bumps [@material-ui/core](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/mui-org/material-ui/releases) - [Changelog](https://github.com/mui-org/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui-org/material-ui/commits/v4.7.1/packages/material-ui) Signed-off-by: dependabot-preview[bot] <[email protected]> * dependabot: config (#253) * update direct deps * run tidy * ignoring cypress 3.7.0 * build(deps-dev): bump @babel/plugin-proposal-class-properties (#255) Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel) from 7.7.0 to 7.7.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.0...v7.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * schedule/rotation: fix endtime calculation bug (#254) * handle future start time in Rotation.EndTime method * add unit test for rotation future start time * remove old redundant comments * ui/profile: prevent adding a notification rule if there are no contact methods (#251) * Disable Add Notification Rule speed dial option if there are no Contact Methods * build(deps-dev): bump style-loader from 1.0.0 to 1.0.1 in /web/src (#256) Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/webpack-contrib/style-loader/releases) - [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/style-loader@v1.0.0...v1.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump github.com/spf13/viper from 1.5.0 to 1.6.1 (#258) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.5.0 to 1.6.1. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.5.0...v1.6.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump eslint from 6.6.0 to 6.7.2 in /web/src (#257) Bumps [eslint](https://github.com/eslint/eslint) from 6.6.0 to 6.7.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.6.0...v6.7.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * twilio : make voice verification calls more user-friendly (#260) * pause and delays between digits * verbose message for voice verification codes * increase timeout for voice message responses * build(deps-dev): bump eslint-plugin-react in /web/src (#262) Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.16.0 to 7.17.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.16.0...v7.17.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps): bump @material-ui/lab in /web/src (#259) Bumps [@material-ui/lab](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-lab) from 4.0.0-alpha.33 to 4.0.0-alpha.35. - [Release notes](https://github.com/mui-org/material-ui/releases) - [Changelog](https://github.com/mui-org/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui-org/material-ui/commits/HEAD/packages/material-ui-lab) Signed-off-by: dependabot-preview[bot] <[email protected]> * ui/profile: added '+' as input adornment to phone field for contact method (#263) * added cm '+' adornment * build(deps-dev): bump file-loader from 4.3.0 to 5.0.2 in /web/src (#238) * build(deps-dev): bump file-loader from 4.3.0 to 5.0.2 in /web/src Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 4.3.0 to 5.0.2. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v4.3.0...v5.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump file-loader from 4.3.0 to 5.0.2 in /web/src Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 4.3.0 to 5.0.2. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v4.3.0...v5.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump file-loader from 4.3.0 to 5.0.2 in /web/src Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 4.3.0 to 5.0.2. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v4.3.0...v5.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * require logo -> import logo * requires -> imports * cypress: use whitelist instead of preserveOnce (#268) * build(deps-dev): bump eslint-plugin-import in /web/src (#267) Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.18.2 to 2.19.1. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.18.2...v2.19.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * cypress: increase timeout threshold for creating schedule (#264) * build(deps): bump luxon from 1.21.2 to 1.21.3 in /web/src (#266) Bumps [luxon](https://github.com/moment/luxon) from 1.21.2 to 1.21.3. - [Release notes](https://github.com/moment/luxon/releases) - [Changelog](https://github.com/moment/luxon/blob/master/changelog.md) - [Commits](moment/luxon@1.21.2...1.21.3) Signed-off-by: dependabot-preview[bot] <[email protected]> * build(deps-dev): bump @babel/core from 7.7.2 to 7.7.5 in /web/src (#265) Bumps [@babel/core](https://github.com/babel/babel) from 7.7.2 to 7.7.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.7.2...v7.7.5) Signed-off-by: dependabot-preview[bot] <[email protected]> * admin: provide URLs and copy links from the admin page (#243) * public URL is now marked as such * add hints for known sections * fix duplicate declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR adds copy-friendly links to config sections on the admin page.
The links are generated on the backend using the same logic and config that would be sent to external systems (like Twilio). It was built using the same tools used for the current config so the UI will pickup new "hints" without updates.
Additionally, the Public URL now has it's "public" flag set.