Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/admin: add message logs notification count line graph #2481

Merged
merged 100 commits into from
Jun 8, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Jun 29, 2022

Part of #2460, related to #2600

  • Updated the top controls to better fit the graph
  • Uses the first and last dates of the currently fetched message logs for the initial graph display
  • Prioritizes using the start/end times for the graph display, if set in the filter controls up top
  • Shows line graph of counts by day on the route for message logs
  • The graph can be hidden under an accordion
  • The page title reads "Message Logs" instead of "message-logs"
  • Notifications that get bundled are omitted from showing (as nothing is actually sent to the user for these log entries)
  • Can change the interval of the graph to go by daily, hourly, or by the minute. Default: daily

Screen Shot 2022-08-08 at 12 57 52 PM

tony-tvu
tony-tvu previously approved these changes Jun 30, 2022
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mastercactapus
Copy link
Member

Jumping on a different issue, but possible TODO: fill in the gaps with zeros. The backend returns sparse data, so the graph only displays counts >0. We could fix this in either place, but it's probably the cleanest/easiest in Go from the service side.

mastercactapus
mastercactapus previously approved these changes Jun 7, 2023
m17ch
m17ch previously approved these changes Jun 7, 2023
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Forfold Forfold dismissed stale reviews from m17ch and mastercactapus via 4782e3e June 8, 2023 17:28
@mastercactapus mastercactapus merged commit 657ede2 into master Jun 8, 2023
@mastercactapus mastercactapus deleted the message-logs-graph branch June 8, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants