-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/wizard: fix wizard character limit #2515
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests ( app/wizard/util.test.js
) for the wizard also need updated to reflect the new expected output
make check
to catch common errors. Fixed any that came up.Description:
Name: already in use
errors whenever a schedule is created with FTS support that has a rotation with a timezone different than its original timezone, which resulted in two rotations with the same names sent to the backend.cannot be more than 64 characters
error when they've exceeded the limit. If a user creates a service that has two schedules without FTS, then they will seecannot be more than 54 characters
error since ' Secondary' is an additional 10 characters subtracted from 64. These scenarios are accounted for in this PR's cypress test.Which issue(s) this PR fixes:
#2488