Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intkeys: return 401 for invalid integration keys #2546

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

mastercactapus
Copy link
Member

Description:
This PR resolves an issue where invalid integration keys would return validation errors resulting in a 400 Bad Request instead of 401 Unauthorized.

Which issue(s) this PR fixes:
Closes #2541

Describe any introduced API changes:
Properly formatted but invalid/deleted integration keys will now return a 401 status code, instead of 400.

Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KatieMSB KatieMSB self-requested a review August 16, 2022 18:48
@mastercactapus mastercactapus merged commit e0a75a7 into master Aug 16, 2022
@mastercactapus mastercactapus deleted the invalid-key-401 branch August 16, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intkeys: wrong response code for missing/invalid key
3 participants