Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switchover: use new db for new db listener #2552

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mastercactapus
Copy link
Member

Description:

  • Fixes a regression that resulted in switchover reporting invalid config for all nodes.
  • Fixes a bug where a node with invalid config on startup may cause the startup of new nodes to fail.

The first was introduced when moving from passing connection strings to using the DB connectors directly for the Listener sqlutil. Previously the code relied on parsed config from the URL which determined which DB to listen to for the ID message. The changes introduced in #2305 incorrectly passed the old.db instance where a message was expected from the new DB.

The second was a long-standing race where an invalid config, which triggers a reset, was detected before the node had fully started and SetApp had not yet been called.

@mastercactapus mastercactapus merged commit 83b79ad into master Aug 10, 2022
@mastercactapus mastercactapus deleted the fix-swo-config-check branch August 10, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants