-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: bugfixes taken out of the swo PR #2580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatieMSB
previously approved these changes
Aug 23, 2022
KatieMSB
approved these changes
Aug 23, 2022
tony-tvu
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is a collection of small fixes that are not SWO-specific.
Which issue(s) this PR fixes:
make start
could fail if thegoalert-postgres
container exists but not currently runningSIZE=
parameter formake regendb
--make regendb SIZE=0.1
will have 10% the normal datamake regendb SIZE=10
will have 10xslowproxy
devtool in favor of an open source alternativespeedbump
truncate
todelete from
so it is caught by switchover triggerssql.DB
anddriver.Connector
to theutil/sqldrv
packagesqlutil.Listener
where it would fail to exit on context cancellationtoSeverity
method that will take the various severity inputs and output the standard set of color values (removes the need to map them everywhere)...
when the FROM-number is unavailable. It will now omit the suggestion as intended in this case.