GraphQL: serviceID should be optional #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
requested changes
Sep 29, 2022
There was a problem hiding this comment.
A couple more changes will need to go with this; if you run make check locally, it should regenerate the necessary files and give you the error for what's missing.
Namely:
- in
graphql2/graphqlapp/service.go, we just need to take the address ofresult.ID - in
graphql2/graphqlapp/heartbeatmonitor.gowe need to account for it now being a pointer -- you can use theCreateIntegrationKeymethod ingraphql2/graphqlapp/integrationkey.gofor an example.
The underlying store methods will handle validation (e.g., checking for empty ServiceID), so it's enough to just handle the change from string to *string in the GraphQL code.
theautoroboto
changed the title
theautoroboto
changed the title
mastercactapus
approved these changes
Sep 30, 2022
tony-tvu
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When creating a new service with a heartbeat monitor, CreateHeartbeatMonitorInput is requiring a serviceID that has not yet been created.
Which issue(s) this PR fixes:
This change will make serviceID optional in the schema for CreateHeartbeatMonitorInput, allowing createService to create the heartbeat monitor when the service is created.