admin: add alert auto-close feature #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2022 18:15
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mastercactapus
requested changes
Oct 25, 2022
|
@Lakshmi2107 let us know if you'd like any help implementing the changes, thanks for the PR! |
|
thank you @mastercactapus. We are good for now. We will update the implementation once done. @Lakshmi2107 |
|
@mastercactapus Updated PR with auto-close changes. Please review. |
mastercactapus
requested changes
Oct 31, 2022
|
@mastercactapus Thanks for the comments. I have pushed all suggested changes. Please review. |
mastercactapus
requested changes
Nov 7, 2022
…2107/goalert into feature/auto-close-alert # Conflicts: # engine/cleanupmanager/db.go
|
@mastercactapus Addressed all review comments. Please check |
mastercactapus
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Looks good!!!
I pushed a couple of tweaks to wrap this up:
- re-ordered things to be AlertCleanup, then AlertAutoClose, everywhere
- Added a small smoke test to validate the functionality
- added a
coalesceto the EP notice query, as it caused a NULL error when there were no escalation policy steps
mastercactapus
changed the title
|
Thanks @mastercactapus |
Forfold
approved these changes
Nov 10, 2022
|
thank you so much @mastercactapus @Lakshmi2107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
GoAlert sends alerts to various communication methods, once the alert is created it will be in unacknowledged state. there are some alerts that are in unack state forever. Any alert created in the goalert especially for monitoring production systems should have some lifecycle and close beyond some time say 24 hrs, otherwise it won't be meaningful.
Which issue(s) this PR fixes:
Fixes #2658
Screenshots:
Additional Info:
Need to add a few rows in config_limits table and add values to the config limit enum
alter type enum_limit_type add value 'maximum_time_to_auto_close_alert';
Rows to be inserted in table config_limits
Max time to auto-close an alert ( in hours )
Example:
"maximum_time_to_auto_close_alert" 3