Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert: add escalation checks #2840

Merged
merged 16 commits into from
Mar 8, 2023
Merged

alert: add escalation checks #2840

merged 16 commits into from
Mar 8, 2023

Conversation

mastercactapus
Copy link
Member

Description:
This PR updates the escalation code to return proper validation errors for:

  • Service in maintenance mode
  • alert already closed
  • alert not found
  • already escalated (since provided timestamp)

Which issue(s) this PR fixes:
Prereq. for #2818

Out of Scope:

Describe any introduced API changes:
escalateAlerts will now only allow escalating a single alert.

@github-actions github-actions bot added the size/m label Mar 6, 2023
@mastercactapus mastercactapus requested a review from KatieMSB March 7, 2023 16:08
KatieMSB
KatieMSB previously approved these changes Mar 7, 2023
@mastercactapus mastercactapus merged commit cf787a2 into master Mar 8, 2023
@mastercactapus mastercactapus deleted the add-escalation-checks branch March 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants