Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/AlertDetailPage: Convert to typescript #2936

Merged
merged 1 commit into from
Apr 17, 2023
Merged

ui/AlertDetailPage: Convert to typescript #2936

merged 1 commit into from
Apr 17, 2023

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Conver to typescript.
Part of #2318

@KatieMSB KatieMSB merged commit e354739 into master Apr 17, 2023
@KatieMSB KatieMSB deleted the alert-detail-page-tsx branch April 17, 2023 14:41
@KatieMSB KatieMSB mentioned this pull request Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@AlaricWhitney AlaricWhitney AlaricWhitney approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @AlaricWhitney