Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration test for slack usergroup feat #3129

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

allending313
Copy link
Contributor

@allending313 allending313 commented Jun 26, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Added happy path integration test in cypress to test slack user group usability in the ui. This included additions to mockslack to support usergroup.list api calls.

https://jira.target.com/browse/NSP-384

@mastercactapus mastercactapus merged commit 0648276 into master Jun 29, 2023
@mastercactapus mastercactapus deleted the slack-usergroup-integration branch June 29, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants