Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove webhook exp flag #3168

Merged
merged 1 commit into from
Jul 13, 2023
Merged

feat: remove webhook exp flag #3168

merged 1 commit into from
Jul 13, 2023

Conversation

allending313
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Removed webhook experimental flag option. On call notifications will have webhook as an option by default as long as webhooks are enabled.

  • integration test ensuring the EP UI works (happy path)
  • integration test ensuring the schedule UI works (happy path)
  • smoke test validating alert notifications work for EP webhooks
  • smoke test validating schedule notifications work for webhooks

@allending313 allending313 merged commit 846c00b into master Jul 13, 2023
@allending313 allending313 deleted the remove-webhook-exp-flags branch July 13, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allending313 @mastercactapus @Forfold