Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/admin: add service metrics data table #3368

Merged
merged 17 commits into from
Oct 27, 2023
Merged

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Oct 16, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds part of the service metrics ui work that includes overall metrics for all services and a table of all services.
Metrics include:

  • Total Services
  • Services with empty Escalation Policies
  • Services without Integration Keys and Heartbeat Monitors
  • Services with stale Alerts (acknowledged alerts older than 2 months)
  • Services nearing or at the Unacknowledged Alert Limit

Which issue(s) this PR fixes:
Part of #3057

Out of Scope:

  • filtering
  • integration key/escalation policy target metrics breakdowns

Screenshots:

Screenshot 2023-10-25 at 10 20 07 AM

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tony-tvu
tony-tvu previously approved these changes Oct 16, 2023
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tony-tvu
tony-tvu previously approved these changes Oct 17, 2023
@github-actions github-actions bot added size/xl and removed size/l labels Oct 25, 2023
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a subheader under Services, could we maybe have some loading text, such as "Loading... This may take a minute."

Also, this could maybe be iterated on later, but thinking about the top cards to be more responsive for various browser sizes. Maybe switch to xs={4} sm={2.4} or something?

Last thing, is perhaps setting the height to the top cards to 100% of their container, so their heights all match:

Screenshot 2023-10-26 at 10 48 18 AM

Co-authored-by: Nathaniel Cook <[email protected]>
Copy link
Collaborator

@ethan-haynes ethan-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KatieMSB KatieMSB merged commit b065948 into master Oct 27, 2023
@KatieMSB KatieMSB deleted the admin-service-metrics-table branch October 27, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants