-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/admin: add service metrics data table #3368
Conversation
Co-authored-by: Tony Vu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rt into admin-service-metrics-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a subheader under Services, could we maybe have some loading text, such as "Loading... This may take a minute."
Also, this could maybe be iterated on later, but thinking about the top cards to be more responsive for various browser sizes. Maybe switch to xs={4} sm={2.4}
or something?
Last thing, is perhaps setting the height to the top cards to 100% of their container, so their heights all match:

web/src/app/admin/admin-service-metrics/AdminServiceMetrics.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathaniel Cook <[email protected]>
web/src/app/admin/admin-service-metrics/AdminServiceMetrics.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
make check
to catch common errors. Fixed any that came up.Description:
This PR adds part of the service metrics ui work that includes overall metrics for all services and a table of all services.
Metrics include:
Which issue(s) this PR fixes:
Part of #3057
Out of Scope:
Screenshots: