apikey: only enforce unique name on non-deleted keys #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
changed the title
KatieMSB
previously approved these changes
Oct 17, 2023
Forfold
previously approved these changes
Oct 17, 2023
Forfold
previously approved these changes
Oct 17, 2023
KatieMSB
approved these changes
Oct 17, 2023
Forfold
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where once a key was deleted, its name could still not be used.
Which issue(s) this PR fixes:
Part of #3007
Additional Info:
This was due to a unique constraint not accounting for the soft-delete functionality.