Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix default value not set for temp sched dialog #3380

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Oct 25, 2023

Closes #3377

Fixes an issue where the default value was not set on the temporary schedule dialog, so the incoming data was not what was expected.

Also resolves a console error where userID is not a valid prop for a native HTML element.

Out of scope:
There's another console error related to findDOMNode being disabled with React.StrictMode enabled. This seems to be an issue with the transition library we are using, as this prop is not seen within our codebase. It will be worth looking into updating this package.

@Forfold Forfold merged commit 6b11138 into master Oct 25, 2023
@Forfold Forfold deleted the temp-sched-bug branch October 25, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Error When Launching "Temporary Schedule" Dialog from Override List
3 participants