Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/service-metrics: Add filtering for admin service metrics #3382

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds filtering for service metrics data table by:

  • Escalation policy targets
  • Integration key targets
  • Label keys and values

Which issue(s) this PR fixes:
Part of #3057

Out of Scope:
Additional metrics around integration key and escalation policy targets.

Screenshots
Filter side drawer:
Screenshot 2023-10-27 at 2 04 54 PM

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KatieMSB KatieMSB merged commit 4d3166f into master Nov 6, 2023
@KatieMSB KatieMSB deleted the admin-service-metrics-filter branch November 6, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants