ui/urql: update admin queries and mutations #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
commented
Nov 7, 2023
|
|
||
| const { data: numData } = useQuery(numInfoQuery, { | ||
| const [{ data: numData, error: queryError }] = useQuery({ | ||
| query: numInfoQuery, |
There was a problem hiding this comment.
Note that pollInterval: 0, has been removed. I did not see an equivalent for urql, though this may be fine to leave as is.
There was a problem hiding this comment.
IIRC, it was there because, initially, carrier info was part of the query (and we'd get charged for each request). But I don't think it's necessary anymore since we broke that out into a mutation in the end.
76 tasks
mastercactapus
requested changes
Nov 8, 2023
mastercactapus
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates
AdminConfig,AdminLimits,AdminNumberLookup,AdminSMSSend, andSlackActionsto useurqlinstead of@apollo/clientfor their queries and mutationsWhich issue(s) this PR fixes:
Part of #3240