Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: convert FormContainer to hooks #3432

Merged
merged 1 commit into from
Nov 8, 2023
Merged

ui: convert FormContainer to hooks #3432

merged 1 commit into from
Nov 8, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Nov 8, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts web/src/app/forms/FormContainer.js component to use hooks.

Which issue(s) this PR fixes:
Fixes: #3044

Out of Scope:
Convert to typescript

@github-actions github-actions bot added the size/m label Nov 8, 2023
@mastercactapus mastercactapus self-requested a review November 8, 2023 15:41
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tony-tvu tony-tvu merged commit 71065b8 into master Nov 8, 2023
@tony-tvu tony-tvu deleted the hooks-form-container branch November 8, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert FormContainer class component to React hooks
3 participants