Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/schedules: flip timezone locale for shifts list #3510

Merged
merged 2 commits into from
Dec 11, 2023
Merged

ui/schedules: flip timezone locale for shifts list #3510

merged 2 commits into from
Dec 11, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Dec 4, 2023

Description:
This PR flips the locale for the schedule shifts list, defaulting to the user's local timezone. The tooltip hover will render the timestamp in the schedule's timezone and will show the full date if there is more than a day difference.

Which issue(s) this PR fixes:
Fixes #3496
Part of #3492

Out of Scope:
Other schedule routes

Screenshots:

PST local, CST schedule:

Screenshot 2023-12-04 at 11 00 03 AM

PST local, Australia/Adelaide (+1 day) schedule:

Screenshot 2023-12-04 at 11 00 17 AM

@github-actions github-actions bot added the size/m label Dec 4, 2023
tony-tvu
tony-tvu previously approved these changes Dec 5, 2023
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a good follow-up to this would be bringing the shifts list up to date with using the Time component -- I'm sure there are a few other places missing it too. I think we need to update it to handle ranges though

@Forfold Forfold merged commit fb38017 into master Dec 11, 2023
@Forfold Forfold deleted the tz branch December 11, 2023 18:38
@Forfold
Copy link
Contributor Author

Forfold commented Dec 11, 2023

@mastercactapus Agreed. I was thinking this page would be a simple update to the Time component but it's doing everything manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui/schedules: Incorrect Schedule Shifts Headers
4 participants