Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: add destinationTypes and destinationFieldValidate queries #3548

Merged
merged 5 commits into from
Dec 28, 2023

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Dec 20, 2023

Description:
Implements two new queries for generic destination support. Additionally, a @experimental directive was added to mark these fields as experimental in the schema.

Run make start EXPERIMENTAL=dest-types to start with this feature turned on.

Query.destinationTypes returns a list of all valid/built-in destination types.

Query.destinationFieldValidate can be used to validate the value of a field.

Examples:

Valid webhook (returns true):

  destinationFieldValidate(input:{
    destType: "builtin-webhook",
    fieldID: "webhook-url",
    value: "http://google.com"
  })

Invalid webhook (returns false):

  destinationFieldValidate(input:{
    destType: "builtin-webhook",
    fieldID: "webhook-url",
    value: "missing-schema"
  })

Which issue(s) this PR fixes:
Part of #2639

Out of Scope:

  • Search-select functionality will be in a subsequent PR.

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:

  • Query.destinationTypes
  • Query.destinationFieldValidate

Additional Info:
A full working implementation of the full suite of API and UI changes is in the generic-destinations branch.

Note: generic-destinations should be considered a POC for the purposes of flushing out the full scope of API changes, the UI code will be cleaned up and merged in pieces with tests.

Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally working as expected on my end.

@mastercactapus mastercactapus merged commit 26c13cb into master Dec 28, 2023
@mastercactapus mastercactapus deleted the dest-types-query branch December 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants