Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/schedules: create confirmation component for editing a temporary schedule #3561

Merged
merged 10 commits into from
Jan 8, 2024

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Dec 29, 2023

Description:
This PR adds a confirmation screen to the temporary schedule dialog (when editing). The experience should remain the same when creating a new temporary schedule.

When a temporary schedule is edited, after clicking on "Next", a new component will render displaying the current temporary schedule's shifts on the left, with the proposed changes on the right. If everything looks good, the user can submit- otherwise, they can click "Back" and continue to make changes.

Gap coverage errors will be handled before this screen.

Which issue(s) this PR fixes:
Closes #3497
Part of #3492

Out of Scope:
N/A

Screenshots:

Screenshot 2023-12-29 at 9 47 43 AM
Screenshot 2023-12-29 at 9 47 28 AM
Screenshot 2023-12-29 at 9 47 54 AM

Additional Info:
An information icon has been added to the gap coverage list items to let the user know they can click on the coverage gap to automatically fill in the times for that range

@Forfold Forfold marked this pull request as ready for review December 29, 2023 17:49
@mastercactapus mastercactapus self-requested a review January 4, 2024 20:35
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Forfold Forfold merged commit baef15a into master Jan 8, 2024
@Forfold Forfold deleted the temp-sched-diff branch January 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui/schedules: add diff confirmation to temp sched edit
3 participants