Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakdown service.spec.ts test logically #3639

Merged
merged 13 commits into from
Feb 22, 2024

Conversation

c0d33ngr
Copy link
Contributor

@c0d33ngr c0d33ngr commented Jan 28, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This issue breakdown the only test available in service.spec.ts file into smaller test cases for ease of read.

Which issue(s) this PR fixes:
Fixes #3622

@c0d33ngr c0d33ngr marked this pull request as ready for review January 30, 2024 04:27
@c0d33ngr
Copy link
Contributor Author

c0d33ngr commented Feb 2, 2024

Hi, I'm working in fixing the failing test cases about 20 total(wide & mobile) but I was able to run the make playwright-run successfully by changing the login timeout to 60000. It seem 30000 wasn't enough or something

@mastercactapus
Copy link
Member

hmm, that still seems like a long time for it to hang/wait -- I'll take a look this week; login should be much quicker

@c0d33ngr
Copy link
Contributor Author

c0d33ngr commented Feb 9, 2024

All the breakdown tests runs successfully now when I run make playwright-run with 60000 as timeout login

@mastercactapus
Copy link
Member

@c0d33ngr sorry for the wait on this one, looks like maybe a commit is missing? seeing some typescript errors in a few places

For the login delay, I'm not seeing that -- is it every time for you?

@c0d33ngr
Copy link
Contributor Author

@mastercactapus I understand. About the errors, I forgot to run make check after making changes but it's fixed now.
Also about login timeout when it was 30000 before now tests didn't run but they run now. My dev setup is Github Codespace
Desktop screenshot

Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, when sufficiently cpu-bound they do run slower, but I'm not seeing any issues on my end otherwise -- looks good, thank you and sorry about the delay getting to this

@mastercactapus mastercactapus merged commit 9e8dd99 into target:master Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playwright: separate out tests logically
3 participants