-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakdown service.spec.ts test logically #3639
Breakdown service.spec.ts test logically #3639
Conversation
Hi, I'm working in fixing the failing test cases about 20 total(wide & mobile) but I was able to run the |
hmm, that still seems like a long time for it to hang/wait -- I'll take a look this week; login should be much quicker |
All the breakdown tests runs successfully now when I run |
@c0d33ngr sorry for the wait on this one, looks like maybe a commit is missing? seeing some typescript errors in a few places For the login delay, I'm not seeing that -- is it every time for you? |
@mastercactapus I understand. About the errors, I forgot to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, when sufficiently cpu-bound they do run slower, but I'm not seeing any issues on my end otherwise -- looks good, thank you and sorry about the delay getting to this
make check
to catch common errors. Fixed any that came up.Description:
This issue breakdown the only test available in
service.spec.ts
file into smaller test cases for ease of read.Which issue(s) this PR fixes:
Fixes #3622