Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: destinations: add user CM destination info resolver #3660

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 7, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds the resolver for the user contact method create, edit, and read functionalities. A separate PR will be created for the UI components that will utilize this new resolver.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screenshots:
N/A

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:

  • add resolver for user CM CRUD operations
  • adds statusUpdatesRequired and supportsStatusUpdates to DestinationTypeInfo to account for destinations that require or support status updates

Additional Info:
You must run with experimental flag to be able to test this PR: make start EXPERIMENTAL=dest-types

mastercactapus
mastercactapus previously approved these changes Feb 7, 2024
Copy link
Contributor

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit 1dcddd1 into master Feb 7, 2024
7 checks passed
@mastercactapus mastercactapus deleted the user-cm-dests-api branch February 7, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants