-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dest: Destination display error handling #3779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/src/app/schedules/on-call-notifications/ScheduleOnCallNotificationsListDest.tsx
Outdated
Show resolved
Hide resolved
web/src/app/schedules/on-call-notifications/ScheduleOnCallNotificationsListDest.tsx
Outdated
Show resolved
Hide resolved
allending313
approved these changes
Apr 2, 2024
ethan-haynes
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be a part of this PR, but maybe we should write some additional tests to catch this type of behavior from happening with other areas we are making changes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes error handling with the new destination API. Namely, it prevents the entire page from breaking (e.g., the escalation policy details page) if any single action is invalid (e.g., archived or invalid slack channel). Instead individual chips/line items will render an error.
The purpose is to ensure in such an event, a user is able to interact with the page and take action to resolve the issue.
Screenshots:
Escalation Policy Details
TODAY

This PR


User Contact Methods
TODAY

This PR

Schedule On-Call Notifications
TODAY

This PR


Describe any introduced user-facing changes:
N/A fixing broken behavior
Describe any introduced API changes:
!! Breaking changes to the destination's API !!
FieldValuePair
no longer containslabel
andisFavorite
these were moved toFieldSearchResult
to separate the twoDestination.displayInfo
return type changed fromDestinationDisplayInfo
to a union ofDestinationDisplayInfo
andDestinationDisplayInfoError
-- rather than failing the entire query with a global error, errors are now returned inlinedestinationFieldSearch
return type changed toFieldSearchConnection
, which was renamed fromFieldValueConnection
to matchFieldSearchResult
Additional Info:
The affected APIs are only used when the
dest-types
experimental flag is enabled.