Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gql-api-keys: only setState once when duplicating key #3792

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Apr 3, 2024

Description:
Fixes an issue where fields on the GQL API key create dialog would reset with each poll.

The new approach leverages the Suspense behavior by setting the initial state/value directly, rather than relying on a useEffect handler.

Closes #3791

@github-actions github-actions bot added the size/s label Apr 3, 2024
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally validated. Ty!

@mastercactapus mastercactapus merged commit a2d2c69 into master Apr 9, 2024
7 checks passed
@mastercactapus mastercactapus deleted the prevent-data-revert-on-dup-key branch April 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API key duplicate resetting schema on poll
3 participants