Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int keys: Add support for externally-managed integration keys #3818

Merged
merged 10 commits into from
Apr 23, 2024

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Apr 17, 2024

Description:
This PR intends to enhance support for externally managed keys by:

  • Allowing each unique "system name" a separate namespace for keys (preventing accidental collisions)
  • Displaying externally managed keys in a separate section
  • Requiring an extra confirmation when deleting an externally managed key

Which issue(s) this PR fixes:
Closes #3716

Screenshots:
image
image
image

Describe any introduced user-facing changes:

  • Integration key list now displays external keys in a separate section
  • Deleting an external key requires an extra confirmation

Describe any introduced API changes:

  • Creating an integration key allows setting an optional externalSystemName
  • IntegrationKey type now has externalSystemName as a field

Additional Info:
Creating a key for validation can only be done through the API /api/graphql/explore

mutation createKey{
  createIntegrationKey(input:{
    name: "Foobar",
    serviceID: "72a85097-3601-43fe-a247-c0ee978333fd"
    type: generic
    externalSystemName: "Yet Another Application"
  }){
    id
  }
}

Copy link
Contributor

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing and validated locally

@mastercactapus mastercactapus merged commit 0fe4b6d into master Apr 23, 2024
7 checks passed
@mastercactapus mastercactapus deleted the ext-int-keys branch April 23, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Integration Key Management with External System Identification
3 participants