Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: fix for notification channel deduplication migration #3971

Merged
merged 9 commits into from
Jul 8, 2024
Merged

engine: fix for notification channel deduplication migration #3971

merged 9 commits into from
Jul 8, 2024

Conversation

mastercactapus
Copy link
Member

Description:
Fixes a big issue with the notification channel deduplication migration.

  • Introduces the ability to add data to the migrations_test.go tests.
  • Updates the dedup migration so other updates will retain the dedup table
  • Uses the dedup table to do a 1-time migration of the schedule_data table as necessary
  • Adds a smoketest that reproduces the bug (try disabling the schedule manager migration code to see the fkey error)

Out of Scope

  • For instances updated between the problematic migration and this fix (nightly builds June 29th - July 9th) another PR will be opened with a fix to bypass the error so schedules don't get stuck.

@mastercactapus
test dedup logic in migrations test
277dd3a
@mastercactapus
Add schedules and schedule_data entries to migrations test
2b5e9b1 
- Added schedules and schedule_data inserts to enhance test coverage
- Introduced uuidJSON function for consistent JSON formatting in tests
@mastercactapus
Add old_created_at to deduplication script
4bf99fd 
- Store old_created_at in temporary table for deduplication
- Ensure old_created_at is restored when rolled back
- Update schema.sql to reflect new table structure
- Adjust unit tests for new JSON structure in schedule_data
@mastercactapus
Add schedule data migration for deduplicated notifications
95760ea 
- Introduce migration logic for deduplicated notification channel IDs
- Add new SQL queries to support the migration
- Persist migration state to avoid redundant processing
- Update struct definitions and data mapping utilities
@mastercactapus
add test for schedule notifications dedup
034c1e0
@github-actions github-actions bot added the size/l label Jul 8, 2024
Forfold
Forfold requested changes Jul 8, 2024
View reviewed changes
Forfold
Forfold previously approved these changes Jul 8, 2024
View reviewed changes
allending313
allending313 previously approved these changes Jul 8, 2024
View reviewed changes
@mastercactapus mastercactapus dismissed stale reviews from allending313 and Forfold via 2942d62 July 8, 2024 20:39
@mastercactapus mastercactapus merged commit 66ef297 into master Jul 8, 2024
7 checks passed
@mastercactapus mastercactapus deleted the nc-dedup-fix branch July 8, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@allending313 allending313 allending313 approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @Forfold @allending313