uik: Refactor config to use specific UIK types #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update UikConfig and related types to UIK-specific structs. - Modify GraphQL schema to match new UIK types. - Consolidate related validation and marshalling functions. - Update dependencies to latest versions. - Replace existing integration key actions with UIK-specific actions. - Ensure UUID compatibility in GraphQL schema.
- Added Arg and SetArg methods for safer argument access in DestV1 - Implemented Scan and Value for UIKConfig - Replaced direct Args map access with Arg method across various modules - Enhanced SignalMessage to support Param method
Corrected the function call parameter from `Params` to `Param` to ensure proper message handling in Slack notifications.
- Replace custom marshalling/unmarshalling logic with built-in GraphQL functions - Remove unneeded imports to streamline codebase and reduce dependencies
Forfold
approved these changes
Jul 10, 2024
allending313
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Centralizes the UIK config from
integrationkey.dbConfigtogadb.UIKConfigand uses the same models for GraphQL, eliminating a lot of copy-struct code.Additionally, fixed the use of UUIDs in structs with GraphQL by telling
gqlgenhow to parse and serialize them.