dest: migrate remaining contact method destinations to the nfydest.Registry
#4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted Twilio SMS and Voice logic into separate packages - Removed redundant validation and display logic - Centralized phone number validation in Twilio package
- Register Twilio SMS and Voice providers during app startup - Refactor Twilio destination type references in GraphQL compat file
- Refactored to use `email` package for Email notifications - Registered `email.NewSender` in the destination registry - Removed redundant SMTP destination handling from GraphQL logic - Centralized email validation and display logic in the new provider
KatieMSB
previously approved these changes
Jul 22, 2024
- Upgrade jest-playwright-preset and @playwright/test dependencies
allending313
previously approved these changes
Jul 22, 2024
- Bumped Storybook packages to 8.2.5 for new features and fixes - Updated mockServiceWorker.js and msw dependencies to 2.3.2 - Added 'fn' usage in story for better test function handling - Adjusted yarn.lock for new package versions and resolutions
allending313
previously approved these changes
Jul 22, 2024
KatieMSB
previously approved these changes
Jul 23, 2024
mastercactapus
dismissed stale reviews from KatieMSB and allending313
via
ea47c5a
KatieMSB
approved these changes
Jul 23, 2024
allending313
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Also regenerated
yarn.lockupdated playwright & storybook deps to fix unrelated build issues.