dest: switch UI and alertlog from type/val to dest #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored notification handling using nfydest package for cleaner code and enhanced modularity. - Added SQL queries and methods in gadb for fetching notification channel and callback types. - Removed old methods for lookup and migrated logic to use new nfydest registry. - Improved error handling and parsing of channel IDs for better reliability.
- Deleted redundant SQL statements for notification channels validation and retrieval.
- Extracted Twilio SMS and Voice logic into separate packages - Removed redundant validation and display logic - Centralized phone number validation in Twilio package
- Register Twilio SMS and Voice providers during app startup - Refactor Twilio destination type references in GraphQL compat file
- Refactored to use `email` package for Email notifications - Registered `email.NewSender` in the destination registry - Removed redundant SMTP destination handling from GraphQL logic - Centralized email validation and display logic in the new provider
- Bumped version in package.json and yarn.lock - Improved compatibility and included updates to dependencies
This reverts commit b35fde5.
This reverts commit cb41d11.
- Consolidate destination lookups into a single method - Replace type-specific lookups with destination-based lookups - Simplify classifier assignment by using registry-based type info - Update dependencies and initialization to support new structure
- Added notification channel store to integration key store initialization - Updated SQL queries to use destination instead of type - Removed deprecated IntKeyEnsureChannel method - Adjusted `setActionChannels` method to validate dynamic actions
- Replace hardcoded type names with dynamic lookup - Add error handling for type and display info lookups - Improve error logging context for better debugging
- Upgrade jest-playwright-preset and @playwright/test dependencies
- Bumped Storybook packages to 8.2.5 for new features and fixes - Updated mockServiceWorker.js and msw dependencies to 2.3.2 - Added 'fn' usage in story for better test function handling - Adjusted yarn.lock for new package versions and resolutions
- Cleans up unnecessary data fetching - Improves query performance and clarity
- Replace `targets` with `actions` in AdminServiceMetrics - Update AdminServiceTable to reflect new `actions` type - Modify useServiceMetrics and useServices for `actions`
- Consolidate target types rendering logic - Refactor AlertDetails to use new renderChipsDest function - Update GraphQL query to reflect new action structure with displayInfo - Improve code readability and maintainability
- Removed unused imports and dependencies - Simplified props and local functions - Streamlined renderTargets function with fewer dependencies
Forfold
reviewed
Jul 24, 2024
Forfold
previously approved these changes
Jul 24, 2024
- Change triggers to execute after update instead of before - Add conditions to trigger only when type or value changes - Update schema file to reflect these changes
Forfold
approved these changes
Jul 29, 2024
allending313
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: