ui: fix edit empy temp sched bug

web/src/app/schedules/ScheduleOverrideDialog.jsx

@@ -42,7 +42,7 @@ export default function ScheduleOverrideDialog(props) {
     removeUserID: '',
     start: DateTime.local().startOf('hour').toISO(),
     end: DateTime.local().startOf('hour').plus({ hours: 8 }).toISO(),
-    ...props.defaultValue,
+    ...(props?.defaultValue ?? {}),
   }
 
   const [step, setStep] = useState(0)
@@ -146,15 +146,12 @@ export default function ScheduleOverrideDialog(props) {
           if (!result.error) props.onClose()
         })
       }
-      onNext={step < 1 ? onNext : null}
+      disableSubmit={step === 0}
+      onNext={onNext}
     />
   )
 }
 
-ScheduleOverrideDialog.defaultProps = {
-  defaultValue: {},
-}
-
 ScheduleOverrideDialog.propTypes = {
   scheduleID: p.string.isRequired,
   onClose: p.func,

web/src/app/schedules/temp-sched/TempSchedDialog.tsx

@@ -109,13 +109,15 @@ export default function TempSchedDialog({
   let defaultShiftDur = {} as DurationValues
 
   const getDurValues = (dur: Duration): DurationValues => {
+    if (!dur) return { ivl: 'days', dur: 1 }
     if (dur.hours < 24 && dur.days < 1)
       return { ivl: 'hours', dur: Math.ceil(dur.hours) }
     if (dur.days < 7) return { ivl: 'days', dur: Math.ceil(dur.days) }
+
     return { ivl: 'weeks', dur: Math.ceil(dur.weeks) }
   }
 
-  if (edit) {
+  if (edit && _value.shifts.length > 0) {
     // if editing infer shift duration
     defaultShiftDur = getDurValues(inferDuration(_value.shifts))
   } else {
@@ -199,6 +201,8 @@ export default function TempSchedDialog({
 
   const hasCoverageGaps = (() => {
     if (q.loading) return false
+    if (!value.shifts || value.shifts.length === 0) return true
+
     const schedInterval = parseInterval(value, zone)
     return (
       getCoverageGapItems(
@@ -288,7 +292,9 @@ export default function TempSchedDialog({
       title={edit ? 'Edit a Temporary Schedule' : 'Define a Temporary Schedule'}
       onClose={onClose}
       onSubmit={handleSubmit}
-      onNext={edit && !submitSuccess ? handleNext : null}
+      disableSubmit={edit && !submitSuccess}
+      onNext={edit ? handleNext : null}
+      disableNext={edit && submitSuccess}
       onBack={edit && submitSuccess ? handleBack : null}
       loading={fetching}
       errors={errs}

web/src/app/util/FilterContainer.jsx

@@ -34,6 +34,12 @@ const useStyles = makeStyles((theme) => {
 export default function FilterContainer(props) {
   const classes = useStyles()
   const [anchorEl, setAnchorEl] = useState(null)
+  const {
+    icon = <FilterIcon />,
+    title = 'Filter',
+    iconButtonProps,
+    anchorRef,
+  } = props
 
   function renderContent() {
     return (
@@ -61,12 +67,11 @@ export default function FilterContainer(props) {
     )
   }
 
-  const { icon, iconButtonProps, anchorRef } = props
   return (
     <React.Fragment>
       <IconButton
         onClick={(e) => setAnchorEl(anchorRef ? anchorRef.current : e.target)}
-        title={props.title}
+        title={title}
         aria-expanded={Boolean(anchorEl)}
         {...iconButtonProps}
         size='large'
@@ -120,8 +125,3 @@ FilterContainer.propTypes = {
   anchorRef: p.object,
   children: p.node,
 }
-
-FilterContainer.defaultProps = {
-  icon: <FilterIcon />,
-  title: 'Filter',
-}