dest: move to DestV1 away from DestType #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed notification.DestType to string for code simplicity - Updated all related function signatures and usages
- Consolidated enable/disable SQL queries - Updated methods to use destination-based enable/disable functions - Simplified contact method parameters to use unified structure
- Simplified destination handling by using gadb.DestV1 - Removed redundant notification package dependency - Introduced NewDestV1 constructor for gadb.DestV1 - Updated all IsKnownDest method signatures accordingly
- Migrate notification handling to use gadb.DestV1 - Update SQL queries to utilize unified UserContactMethod struct - Simplify destination hash generation for consistency - Ensure database functions properly handle unified structure for DestV1
Corrects the parameter used to fetch the original message status by using the destination's ID directly, ensuring accurate lookups.
KatieMSB
approved these changes
Jul 30, 2024
allending313
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates code using
notification.Destas a comparable value to useDestHashinstead along with updating some signatures to usegadb.DestV1directly instead of type/value.