heartbeat: allow muting a heartbeat monitor #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update database schema to include `disable_reason` column - Modify GraphQL input/output types and resolvers - Refactor SQL queries and Go store functions to support `disable_reason` - Upgrade sqlc version from v1.26.0 to v1.27.0 - Introduce Interval utility in `sqlutil` for handling durations
- Replace 'DisableReason' with 'MutedReason' for clarity - Update schema migrations and SQL queries accordingly - Adjust GraphQL schema and API input/output definitions - Align database and Go models with the new terminology
- Replace `MutedReason` with `Muted` across codebase - Update SQL queries and GraphQL schema to reflect changes - Adjust validation to accommodate new field name - Modify test cases to test updated muting logic
… of disable reason
AlaricWhitney
requested changes
Nov 26, 2024
AlaricWhitney
approved these changes
Nov 27, 2024
KatieMSB
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to mute a heartbeat monitor through the API.
heartbeatpackage has been migrated tosqlcOut of Scope:
Describe any introduced API changes:
mutedvalue that if non-empty results in no new alerts being generated.