engine/processinglock: migrate to sqlc #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted raw SQL usage to typed SQL methods in `gadb` - Added comment explaining version discrepencies
m17ch
approved these changes
Nov 4, 2024
KatieMSB
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the module locking code to use
sqlcfor database queries, but is behaviorally the same.One notable change: on startup only a module version mismatch will log an error. This should never happen during normal operation, including during GoAlert updates. However, in the event of rolling back an engine instance to a version of GoAlert that is incompatible with one or more modules will now log an error to indicate the issue.
This is important as a version mismatch will result in the engine not processing that type of data.