logging: introduce slog.Logger #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new `Logger` using `slog` for better structure - Continued use of `LegacyLogger` to maintain compatibility - Replaced custom logger with `slog-logrus` for SMTP and other components - Refactored error handling in `multiListener` to utilize `slog` - Updated tests and dependencies to align with new logging strategy
KatieMSB
previously approved these changes
Nov 8, 2024
- Enforced the presence of a logger in application configuration. - Integrated structured logging using slog and logrus for improved logging capabilities in test harness.
KatieMSB
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduced
*slog.Loggerto theAppstruct as an eventual replacement for the custom logging package.This can also be used as a logger to pass into other tools that take an *slog.Logger argument.