Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/apikeys: add CodeMirror editor for editing keys #4149

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Conversation

mastercactapus
Copy link
Member

Description:
This PR introduces CodeMirror6 when creating GraphQL API keys. This is to lay the groundwork for:

  • markdown /w preview
  • Better experience for Expr fields
  • versioned API keys /w diff output

Out of Scope:

  • markdown and expr modes/editors will be done separately

Screenshots:
image

Describe any introduced user-facing changes:
Creating GraphQL API keys is now done in an editor rather than a text field

  • dialog is wider
  • syntax highlighting
  • format option
  • auto-complete

Describe any introduced API changes:
N/A

@ethan-haynes ethan-haynes merged commit 33bf9a3 into master Nov 18, 2024
7 checks passed
@ethan-haynes ethan-haynes deleted the codemirror branch November 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants