Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uik: Update rules list for single-dialog and re-ordering #4195

Merged
merged 21 commits into from
Dec 13, 2024
Merged

uik: Update rules list for single-dialog and re-ordering #4195

merged 21 commits into from
Dec 13, 2024

Conversation

mastercactapus
Copy link
Member

Description:
Reworks rule editing to use the single-dialog flow for actions and so that behaviors can be read at a glance.

Which issue(s) this PR fixes:
Part of #4187

Screenshots:
image
image
image
image

Describe any introduced user-facing changes:
On the UIK edit page:

  • Conditions and actions are now shown inline
  • Users may now re-order rules in the same way as EP steps
  • Action editing updated to match Default Actions

Describe any introduced API changes:

  • Add the ability to directly set actions on a rule, as well as re-order rules via KeyUpdateInput

@mastercactapus
feat: add edit functionality to destination chips and actions list
f478192
@mastercactapus
feat: implement UniversalKeyActionDialog for adding and editing actions
942733b
@mastercactapus
feat: add default action retrieval functionality and adjust form dial…
24f3b3d 
…og padding
@mastercactapus
feat: add setRuleActions input for updating actions of a specific rule
ddbf95f
@mastercactapus
feat: integrate error handling in UniversalKeyActionDialog for improv…
53fd1dd 
…ed user feedback
@mastercactapus
feat: remove unused name field from rules in UniversalKeyActionDialog
5c67a5c
@mastercactapus
Merge branch 'master' into uik-rule-cards
e796507
@mastercactapus
feat: enhance form and destination components with edit functionality…
a5bbbec 
… and improved UI
@mastercactapus
fix: update default action parameters to fallback on request body values
a9e226a
@mastercactapus
refactor: remove DefaultActionEditDialog component and associated logic
4e25d6d
@mastercactapus
refactor: comment out setRuleActions logic for future API change
39757ff
@mastercactapus
fix: add data-testid to no actions message for improved testing
eb3cb43
@mastercactapus
Merge branch 'uik-default-action-ui' into uik-rule-cards
a129889
@mastercactapus
refactor: simplify rule mapping by removing unused index parameter
ca667b2
@mastercactapus
refactor: remove UniversalKeyActionsForm and associated story files
a195b72
@mastercactapus
refactor: enhance action management in UniversalKeyActionDialog with …
843d622 
…delete option
@mastercactapus
refactor: update test selectors to improve specificity in UI interact…
028bdb6 
…ions
@mastercactapus
refactor: remove unused Switch component from UniversalKeyActionDialog
6f5cf74
@mastercactapus
refactor: add setRuleOrder to UpdateKeyConfigInput for rule reordering
22952be
@mastercactapus
Merge branch 'master' into uik-rule-cards
0888ce2 
# Conflicts:
#	web/src/app/services/UniversalKey/UniversalKeyActionDialog.tsx
#	web/src/app/services/UniversalKey/UniversalKeyActionsList.tsx
@ethan-haynes ethan-haynes merged commit 5be8cf0 into master Dec 13, 2024
7 checks passed
@ethan-haynes ethan-haynes deleted the uik-rule-cards branch December 13, 2024 16:19
@mastercactapus mastercactapus mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-haynes ethan-haynes ethan-haynes approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @ethan-haynes @KatieMSB