-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basic support for linux riscv64 #12602
base: dev
Are you sure you want to change the base?
Conversation
Package Changes Through 552f960There are 5 changes which include tauri-cli with minor, tauri with patch, tauri-utils with minor, tauri-bundler with minor, @tauri-apps/cli with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Thanks for the PR. Did you only test |
I tested
Yes. But adding riscv there should make the code future-proof when the appimage tools start supporting riscv. |
i don't care too much about
That is in the very far future (or potentially never) and with your changes the user facing error now isn't as clear anymore. Without your changes the user will get a "unsupported platform" error and now they'll probably get an http error instead. |
Thanks! I will test the rpm bundler. Marking this PR as draft until test is done.
Your concern is certainly valid. We riscv64 packagers are generally familiar with http error encountered when a prebuilt asset isn't available for riscv64. But for normal users that error might be a little cryptic. I will remove the changes to the appimage code. |
I have dropped the changes to appimage bundler. I think this PR is ready for review now. |
This PR introduces basic support for riscv64.
Tests done on Arch Linux riscv64:
closes #7522 (A new release on npm should be necessary)
closes #10945