Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate fixed values #1013

Merged
merged 2 commits into from
Apr 13, 2024
Merged

feat: Validate fixed values #1013

merged 2 commits into from
Apr 13, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Apr 13, 2024

📒 Description

Until now we skipped parsing and validated fixed values, but this interferes with the parsing unions of classes with the same fields but with different fixed values.

Resolves #1012

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9be40c4) to head (73ddc8c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          117       117           
  Lines         9188      9211   +23     
  Branches      2181      2186    +5     
=========================================
+ Hits          9188      9211   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit ca048a8 into main Apr 13, 2024
15 checks passed
@tefra tefra deleted the fix-1012 branch April 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing XML to a class: A sequence of alternatives is wronly parsed
1 participant