Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dnstwist json keynames in core.py #57

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Update dnstwist json keynames in core.py #57

merged 1 commit into from
Dec 21, 2021

Conversation

RomainPisters
Copy link
Contributor

By default dnstwist doesn't work because the if statements in /app/watcher/dns_finder/core.py make references to 'dns-xx' (hyphen) instead of 'dns_xx' (underscore). After applying these changes dnstwist works as expected.

As a test I've added example.com and found the following contents (snippet) being written to /app/watcher/dns_finder/data/list.json:

[
    {
        "dns_a": [
            "93.184.216.34"
        ],
        "dns_aaaa": [
            "2606:2800:220:1:248:1893:25c8:1946"
        ],
        "dns_mx": [
            ""
        ],
        "dns_ns": [
            "a.iana-servers.net"
        ],
        "domain": "example.com",
        "fuzzer": "*original"
    },

By default dnstwist doesn't work because the `if` statements in /app/watcher/dns_finder/core.py make references to 'dns-xx' (hyphen) instead of 'dns_xx' (underscore). After applying these changes dnstwist works as expected.

As a test I've added `example.com` and found the following contents (snippet) being written to /app/watcher/dns_finder/data/list.json:

```
[
    {
        "dns_a": [
            "93.184.216.34"
        ],
        "dns_aaaa": [
            "2606:2800:220:1:248:1893:25c8:1946"
        ],
        "dns_mx": [
            ""
        ],
        "dns_ns": [
            "a.iana-servers.net"
        ],
        "domain": "example.com",
        "fuzzer": "*original"
    },
```
@Felix83000
Copy link
Collaborator

Hello,

First of all, thank you for your help!

I tested it and you are right, the JSON format just changed in the last release of dnstwist. Hence, it do not work anymore.

I will merge your pull request and create a new release.

Sincerely,
Félix

@Felix83000 Felix83000 merged commit 9e13340 into thalesgroup-cert:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants