Additional connection args #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow http proxy with basic auth Allow setting the ssl_context for cases where CA certs are in another location
|
Please integrate directly into aiohttp3 |
|
Do you have an example for a use case scenario? |
|
I'm developing an intergration into a monitoring platform (Splunk) to send out alerts (e.g. confidential security alerts etc). For security reasons, corporate monitoring platforms are always behind a web proxy and can't directly connect to the gateway. Regarding the ssl_context, in the case of Splunk. I have to use the integrated python3.7 interpreter, which does not pick up the certfile automatically. Possibly, if a https proxy is used, additional certificates may have to be added to the certstore also. A handful of joint Gateway/Splunk users would be happy to have an integration :) |
lgrahl
added a commit
that referenced
this pull request
May 17, 2021
This allows to add arbitrary arguments to each `get` and `post` call. It
can be used to add proxy arguments:
Connection(session_kwargs={'proxy': <your-proxy>})
See the aiohttp docs for details:
https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support
Supersedes and closes #49
lgrahl
added a commit
that referenced
this pull request
May 17, 2021
This allows to add arbitrary arguments to each `get` and `post` call. It
can be used to add proxy arguments:
Connection(session_kwargs={'proxy': <your-proxy>})
See the aiohttp docs for details:
https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support
Supersedes and closes #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for http proxy with basic auth
Add support for setting the ssl_context for cases where CA certs are in another location