diverse improvements (IMO) #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://gateway.threema.ch/de/developer/e2e, the 'padded-data' description states that the sum of 'data' and 'pad-length' should be at least 32. This was not enforced by the code.
The encrypt help output says that two lines (nonce and encrypted text) are printed. Remove an extra empty line to conform to the description.
There are circumstrances in which this is a more natural way to pass the message.
|
|
|
Ping? |
Merged
|
Thanks 👍! I included pretty much all of these in #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to drop anything you don't like!