Refactor code for getting time bucket function Oid #7042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
continuous_aggregate
time_bucket
tech-debt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7042 +/- ##
==========================================
+ Coverage 80.06% 81.76% +1.69%
==========================================
Files 190 200 +10
Lines 37181 37345 +164
Branches 9450 9740 +290
==========================================
+ Hits 29770 30535 +765
+ Misses 2997 2891 -106
+ Partials 4414 3919 -495 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
from
8821c21 to
c4ce36e
Compare
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
3 times, most recently
from
b29738a to
0ffb56d
Compare
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
7 times, most recently
from
e3b7365 to
1b1883e
Compare
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
2 times, most recently
from
d9b9828 to
bd26813
Compare
mkindahl
approved these changes
Jun 25, 2024
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
2 times, most recently
from
0d3b6e1 to
16ca1af
Compare
svenklemm
approved these changes
Jun 26, 2024
This is a small refactoring for getting time bucket function Oid from a view definition. It will be necessary for a following PRs for completely remove the uncessary catalog metadata table `continuous_aggs_bucket_function`. Also added a new SQL function `cagg_get_bucket_function_info` to return all `time_bucket` information based on a user view definition.
fabriziomello
force-pushed
the
cagg_refactor_get_bucket_function_oid
branch
from
16ca1af to
aab6d93
Compare
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 12, 2024
In timescale#7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 12, 2024
In timescale#7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 13, 2024
In timescale#7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 16, 2024
In timescale#7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
fabriziomello
added a commit
that referenced
this pull request
Dec 16, 2024
In #7042 we refactored the code for getting the time bucket function info to read information from the stored query tree on Postgres metadata. But when an origin was not specified it was returning a wrong value instead of NULL. Fixed it by properly dealing with non-defined origin and also simplified a bit the code to process time bucket parameters.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 19, 2025
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 19, 2025
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 20, 2025
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 20, 2025
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 21, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 21, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 21, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 21, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Feb 24, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
added a commit
that referenced
this pull request
Feb 25, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from #7042 refactoring PR.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from #7042 refactoring PR. (cherry picked from commit 41841b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring for getting time bucket function Oid from a view definition. It will be necessary for a following PRs for completely remove the unnecessary catalog metadata table
continuous_aggs_bucket_function.Also added a new SQL function
cagg_get_bucket_function_infoto return alltime_bucketinformation based on a user view definition.Disable-check: force-changelog-file