Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choco-info: add French translation #11299

Merged
merged 34 commits into from
Oct 28, 2023
Merged

choco-info: add French translation #11299

merged 34 commits into from
Oct 28, 2023

Conversation

Dev7g
Copy link
Contributor

@Dev7g Dev7g commented Oct 27, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Dev7g and others added 30 commits October 18, 2023 15:58
choco-upgrade: add French translation  (tldr-pages#11217)
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@github-actions github-actions bot added the translation Issues requesting translating pages from English to other languages. label Oct 27, 2023
@sebastiaanspeck sebastiaanspeck changed the title choco-new: add french translation choco-new, choco-info: add french translation Oct 27, 2023
@sebastiaanspeck sebastiaanspeck changed the title choco-new, choco-info: add french translation choco-new, choco-info: add French translation Oct 27, 2023
@sebastiaanspeck sebastiaanspeck changed the title choco-new, choco-info: add French translation choco-info: add French translation Oct 27, 2023
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, but adding a space between example description and : is an informal rule, as described here.

Co-authored-by: Sebastiaan Speck <[email protected]>
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

@kbdharun kbdharun merged commit d72c3a0 into tldr-pages:main Oct 28, 2023
# choco info

> Afficher des informations détaillées sur un forfait avec Chocolatey.
> Plus d'information: <https://chocolatey.org/docs/commands-info>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Plus d'information: <https://chocolatey.org/docs/commands-info>.
> Plus d'information : <https://chocolatey.org/docs/commands-info>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a space needed here according to our rules? @kbdharun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a space needed here according to our rules? @kbdharun

Yeah, Nice catch (I thought you included this in your initial suggestion 😅). Feel free to update it in new PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the review was still pending.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a new PR: #11318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants