Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-guide: add and update documentation about URLs #11320

Merged
merged 3 commits into from
Oct 30, 2023
Merged

style-guide: add and update documentation about URLs #11320

merged 3 commits into from
Oct 30, 2023

Conversation

Magrid0
Copy link
Member

@Magrid0 Magrid0 commented Oct 28, 2023 •
edited by kbdharun
Loading

Changes

  • Add preference for command line reference or man page.
  • Add requirement to enclose links inside angular brackets.
  • Add information about versioned and Microsoft Learn links.

@Magrid0 Magrid0 requested a review from kbdharun October 28, 2023 10:18
@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Oct 28, 2023
@Magrid0 Magrid0 mentioned this pull request Oct 28, 2023
Closed
70 tasks
@kbdharun
Copy link
Member

kbdharun commented Oct 28, 2023 •
edited
Loading

Hi, I am marking this as draft as there is much more to document about URLs (will do it all in this PR soon)

@kbdharun kbdharun marked this pull request as draft October 28, 2023 10:21
@kbdharun kbdharun changed the title STYLE-GUIDE: Edit page style-guide: add and update documentation about URLs Oct 28, 2023
@kbdharun kbdharun self-assigned this Oct 28, 2023
@kbdharun kbdharun marked this pull request as ready for review October 30, 2023 04:03
@kbdharun kbdharun requested a review from acuteenvy October 30, 2023 04:04
sebastiaanspeck
sebastiaanspeck requested changes Oct 30, 2023
View reviewed changes
@kbdharun @sebastiaanspeck
Apply suggestions from code review
4d9c6ef 
Co-authored-by: Sebastiaan Speck <[email protected]>
@sebastiaanspeck sebastiaanspeck merged commit 54a5de5 into tldr-pages:main Oct 30, 2023
@acuteenvy acuteenvy removed their request for review October 30, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

Assignees

@kbdharun kbdharun

Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Magrid0 @kbdharun @sebastiaanspeck