Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: update maintainers guide #11862

Merged
merged 4 commits into from
Dec 28, 2023
Merged

cleanup: update maintainers guide #11862

merged 4 commits into from
Dec 28, 2023

Conversation

kbdharun
Copy link
Member

  • The PR title conforms to the recommended templates.

This PR updates the maintainer's guide to complete the remaining tasks in the tracker issue.

Changes

  • Document preference to include the coauthored part in the commit message for non-trivial PRs.
  • Document preference to use "decision" label for PRs that need discussion (and shouldn't be merged).
  • Add suggested time requirement for new additions.
  • Add documentation on handling failing actions/workflows and managing waiting CLA checks.

@kbdharun
cleanup: update maintainers guide
84bb460 
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@kbdharun kbdharun requested a review from sbrl as a code owner December 27, 2023 13:37
@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Dec 27, 2023
@kbdharun kbdharun mentioned this pull request Dec 27, 2023
Closed
70 tasks
kbdharun
kbdharun commented Dec 27, 2023
View reviewed changes
acuteenvy
acuteenvy reviewed Dec 27, 2023
View reviewed changes
@kbdharun kbdharun mentioned this pull request Dec 28, 2023
Merged
@sebastiaanspeck sebastiaanspeck merged commit 99a6254 into main Dec 28, 2023
@sebastiaanspeck sebastiaanspeck deleted the docs/maintainers-guide branch December 28, 2023 16:32
@kbdharun kbdharun removed the request for review from acuteenvy December 28, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@acuteenvy acuteenvy acuteenvy left review comments

@gutjuri gutjuri gutjuri approved these changes

@sbrl sbrl Awaiting requested review from sbrl sbrl is a code owner

Assignees
No one assigned
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbdharun @sebastiaanspeck @gutjuri @acuteenvy