Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small improvements/fixes #127

Merged
merged 3 commits into from
Jun 9, 2014
Merged

Various small improvements/fixes #127

merged 3 commits into from
Jun 9, 2014

Conversation

chaoflow
Copy link
Contributor

@chaoflow chaoflow commented Jun 9, 2014

No description provided.

@tomerfiliba
Copy link
Owner

@chaoflow - about the ANSI colors change, be sure to add if sys.stdout.isatty(), and do it only on posix-systems (e.g., not windows)

@chaoflow
Copy link
Contributor Author

chaoflow commented Jun 9, 2014

pushed

tomerfiliba added a commit that referenced this pull request Jun 9, 2014
Various small improvements/fixes
@tomerfiliba tomerfiliba merged commit 5e3beb9 into tomerfiliba:master Jun 9, 2014
@tomerfiliba
Copy link
Owner

thanks. that got me thinking that a colors would be useful in general. i'll add something more general to plumbum.cli.terminal.

@chaoflow
Copy link
Contributor Author

chaoflow commented Jun 9, 2014

@tomerfiliba, @coroa: I'm currently investigating https://github.com/mitsuhiko/click as an alternative for cli parsing for https://github.com/chaoflow/tpv.cli. You might want to take a look before implementing more generic colour support - plumbum.cli could be based/replaced by click.

@henryiii
Copy link
Collaborator

By the way, colored is a nice library for colors in Python. I would love to have something built in, though, especially with context manager support, like I use here.

@henryiii henryiii mentioned this pull request Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants