SwitchAttr support of values via environment variables #216
Conversation
| # Extracting arguments from environment variables | ||
| envindex = 0 | ||
| for env, swinfo in self._switches_by_envar.items(): | ||
| envindex-=1 |
There was a problem hiding this comment.
what is the negative index used for?
There was a problem hiding this comment.
SwitchParseInfo requires index, which later is used for sorting, I think that using same index as before will be wrong, command line arguments and environment variables arguments are not really same indexes. But since it's used later for sorting(and probably some other things that I did not notice) - indexes are required, so negative is like "pre-command line " indexes
But maybe you have another idea how to handle this
|
added some comments -- thanks! |
|
Very handy idea! I can help add docs when it's ready. Sent from my iPhone
|
SwitchAttr now receives envname kwarg If both environment variable and command line argument provided - command line wins(considered override) Environment variables does not have list syntax at the moment (single value will be passed as list, same as single value with command line attribute)
|
Updated basing on comments, squashed, ready to merge |
SwitchAttr support of values via environment variables
No description provided.