Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #327 #328

Merged
merged 2 commits into from
Jun 15, 2017
Merged

Fix #327 #328

merged 2 commits into from
Jun 15, 2017

Conversation

AndydeCleyre
Copy link
Contributor

Fix #327 in one of two obvious ways. prompt type defaults to str, to match docs.

Fix tomerfiliba#327 in one of two obvious ways. prompt type defaults to str, to match docs.
@henryiii
Copy link
Collaborator

Can you add a note to the changelog, too, since this could possibly change code for someone who depends on the default parameter? Otherwise I think this is the correct way to change it.

@coveralls
Copy link

coveralls commented Jun 15, 2017

Coverage Status

Coverage decreased (-0.02%) to 81.057% when pulling 522c1b7 on AndydeCleyre:patch-3 into 76b7bea on tomerfiliba:master.

@AndydeCleyre
Copy link
Contributor Author

Let me know if it's a problem that my editor murdered a bunch of trailing spaces in the changelog.

@henryiii
Copy link
Collaborator

henryiii commented Jun 15, 2017

Trailing spaces deserve to be murdered :) Looking good, will merge when the CI finishes.

@henryiii henryiii merged commit de47645 into tomerfiliba:master Jun 15, 2017
@henryiii
Copy link
Collaborator

Thanks!

@AndydeCleyre
Copy link
Contributor Author

Thank you, this continues to be an amazing project.

@coveralls
Copy link

coveralls commented Jun 15, 2017

Coverage Status

Coverage decreased (-0.4%) to 80.721% when pulling b962c3d on AndydeCleyre:patch-3 into 76b7bea on tomerfiliba:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 80.721% when pulling b962c3d on AndydeCleyre:patch-3 into 76b7bea on tomerfiliba:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants