-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #327 #328
Fix #327 #328
Conversation
Fix tomerfiliba#327 in one of two obvious ways. prompt type defaults to str, to match docs.
Can you add a note to the changelog, too, since this could possibly change code for someone who depends on the default parameter? Otherwise I think this is the correct way to change it. |
…pe from int -> str) to changelog
Let me know if it's a problem that my editor murdered a bunch of trailing spaces in the changelog. |
Trailing spaces deserve to be murdered :) Looking good, will merge when the CI finishes. |
Thanks! |
Thank you, this continues to be an amazing project. |
Fix #327 in one of two obvious ways. prompt type defaults to str, to match docs.